Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add setting configuration for relationships #68

Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat: add setting configuration for relationships #68

merged 1 commit into from
Jul 11, 2023

Conversation

johanseto
Copy link
Collaborator

@johanseto johanseto commented Jul 10, 2023 •
edited
Loading

Description

This add the possibility to configure the course_overview mapping and user mapping via django settings using
COURSE_EXPERIENCE_SETTINGS
Know you can configure the relationship extra field via settings in tenant config.

"COURSE_EXPERIENCE_SETTINGS": {
    "COURSE_OVERVIEW_EXTRA_FIELD_MAPPING": {
        "ultra_name": "courseultra",
        "course_key": "instance__field"
    },
    "USER_EXTRA_FIELD_MAPPING": {
        "mega_name": "userultra",
        "user_key": "user__field"
    }
}

Testing instructions

Clone repo and add variable keys to configure course_experience_keys for relationship in tenant config as above.

After

Peek 2023-07-10 18-32

Additional information

related jira story:
https://edunext.atlassian.net/jira/software/c/projects/FUTUREX/boards/36?modal=detail&selectedIssue=FUTUREX-459

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@johanseto
feat: add setting configuration for relationships
1bc8d47 
This add the possibility to configure the course_overview mapping
and user mapping via django settings using
`COURSE_EXPERIENCE_SETTINGS`

chore: apply suggestions from code review

Co-authored-by: Andrey Cañon <[email protected]>

chore: docstring typo
@johanseto johanseto force-pushed the jlc/settings_extra_attributes_mapping branch from 023d7a0 to 1bc8d47 Compare July 11, 2023 22:56
@johanseto johanseto merged commit 7366ca1 into master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-canon andrey-canon andrey-canon approved these changes

Assignees

@andrey-canon andrey-canon

Labels
course_experience size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanseto @andrey-canon